Makes sure primary toggle toggles both nav regions #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re: 352-in-header-js-primary-toggle-now-only-toggles-primary-nav
finnlewis
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Confirmed the behaviour and that this pull request fixes it.
See #352 (comment) for description.
Current behaviour of the menu toggle with localgov_demo:
With this pull request:
Let's get this merged and released, thanks @ctorgalson !
|
Don't thank me @finnlewis, it was me that broke it in the first place 🤦. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should restore the functionality broken by #334.