8000 sets colour for title on death of person alert by markconroy · Pull Request #311 · localgovdrupal/localgov_base · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sets colour for title on death of person alert #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2022
Merged

sets colour for title on death of person alert #311

merged 2 commits into from
Oct 25, 2022

Conversation

markconroy
Copy link
Member

Closes #310

@markconroy markconroy mentioned this pull request Oct 24, 2022
Merged
@andybroomfield
Copy link
Contributor

I'd be happy with this, however see my comment as I think there is a better solution.

.localgov-alert-banner .localgov-alert-banner__title {
  color: inherit;
}

@markconroy
Copy link
Member Author

@andybroomfield inherit is fine, but means you need to add specific CSS to override it in your sub-theme. I think that's appropriate for the CSS in your module, but in the base theme we are trying to make things override-able via a CSS variable. So in this case, to change the color of that title, you just need to reset what that variable is in your variables.css file.

@markconroy markconroy marked this pull request as ready for review October 25, 2022 07:39
@andybroomfield
Copy link
Contributor
andybroomfield commented Oct 25, 2022 •
edited
Loading

@markconroy fair enough, just an FYI, the bug exists for all the alert banner kinds, not just notable person. Its just we don't notice it since we set the colour of the text to black on those banners. The h2 colour is currently setting it so they will change if someone changes the h2 colour.

Screenshot 2022-10-25 at 9 29 58 am

@markconroy
Copy link
Member Author

PR updated, so we can cover each banner type.

andybroomfield
andybroomfield approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor
@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great now, thanks @markconroy

@markconroy markconroy merged commit b1d464e into 1.x Oct 25, 2022
@keelanfh keelanfh mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybroomfield andybroomfield andybroomfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title colour for death of a notable person alert banner
2 participants
@markconroy @andybroomfield
0