8000 adds sitewide search theming by markconroy · Pull Request #265 · localgovdrupal/localgov_base · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

adds sitewide search theming #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

adds sitewide search theming #265

merged 1 commit into from
Aug 9, 2022

Conversation

markconroy
Copy link
Member
@markconroy markconroy commented Aug 9, 2022 •
edited
Loading

Looks like we are not attaching our sitewide search library to our theme, and even if we were, we could still make things look a lot nicer by default.

Before:

Screenshot 2022-08-09 at 12 55 23

After:

Screenshot 2022-08-09 at 12 58 19

finnlewis
finnlewis approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member
@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @markconroy - definitely an improvement!

@markconroy markconroy merged commit 2961696 into 1.x Aug 9, 2022
@markconroy markconroy mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

@msayoung msayoung Awaiting requested review from msayoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markconroy @finnlewis
0