Change background colour on guide page navigation #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @keelanfh - looks pragmatic to me. Perhaps @markconroy could you check and merge if all good? |
|
I noticed this myself last week. I think we should change --color-grey-light to a colour that is lighter than --color-grey-medium for sure. We fixed this in the |
|
@keelanfh do you want to update the PR to also set --color-grey-light to something lighter than the default grey? |
Make it halfway between --color-grey-lighter and --color-grey-medium
|
@markconroy I've updated that now - from a search, it doesn't look like that variable is used anywhere else, so shouldn't have any implications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background colour on guide pages isn't WCAG2.1AA compliant with
--color-link(--color-accent) used for links in this block (both in base and Scarfolk, as well as other colours people might commonly choose):I've suggested a fix for this where we set the background colour to
--color-grey-lighter, which should give better contrast with a range of colours.Incidentally,
--color-grey-lightis actually darker than--color-grey-medium- there might be a good reason for this, but it does seem a bit counterintuitive when you look down the list of CSS variables...Same change suggested for
.service-landing-page__contactfor the same reason - the contact box includes email and web addresses which get link styling applied too.