Add a template for the new link component #220
Conversation
|
@markconroy another one that @msayoung would like your eyes on before merging. :) |
css/components/link.css
Outdated
| margin-bottom: var(--vertical-rhythm-spacing); | ||
| } | ||
|
|
||
| .link-block__title-icon { | ||
| flex-shrink: 0; | ||
| margin-right: var(--spacing-smaller); |
There was a problem hiding this comment.
We should probably create variables for these margins, so it's easier for sub-themes to override them
There was a problem hiding this comment.
I realised we didn't need that margin-bottom anyway
There was a problem hiding this comment.
Should we create a variable for margin-right here? Something like --link-title-icon-margin?
css/components/link.ie11.css
Outdated
| margin-bottom: 1.5rem; | ||
| } | ||
|
|
||
| .link-block__title-icon { | ||
| margin-right: 0.5rem; |
There was a problem hiding this comment.
Let's use variables for these margins
| <div class="link-block__title-wrapper"> | ||
| {% include "@localgov_base/includes/icons/icon.html.twig" with { | ||
| icon_name: title_icon, | ||
| icon_wrapper_element: 'div', |
There was a problem hiding this comment.
I think div is the "sensible default", so does not need to be included here as it is set automatically.
There was a problem hiding this comment.
do you mean the sensible default for the icon?
if so then this div is wrapping the icon and the text and flexing them. but I may have misunderstood :)
There was a problem hiding this comment.
I mean the div on line 64 icon_wrapper_element: 'div', - the icon template uses div by default, so you only need to put a value in there is you want to use span or something elsse.
| @@ -0,0 +1,80 @@ | |||
| {# | |||
There was a problem hiding this comment.
Looks like this file is a duplicate
No description provided.