Fix/1.x/776 guides prev next block template prints url fragement twice #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comments This task is already performed in localgov_base.theme, *and* in that context it's not necessary to pre-render the URL (which is more efficient).
- window.location always includes a hash property, even if it's empty, - if it's not empty, it always takes the form of an id selector (e.g. #foo-bar), - using context + once prevents this from running multiple times
It's part of a library, so it runs only where it's supposed to 🤦♂️.
|
Just realized while walking the dog this fails to address a minor edge-case. I'll fix it. |
- if it exists, it'll be at least '#', but that's not a valid id selector - the length check ensures that we at least have the hash character plus one character, thus a valid selector
|
Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #776
What does this change?
This makes the following changes:
guides-prev-next-block.html.twigtemplate to its pre Prev-Next SDC condition: namely it no longer sets a URL fragment on each of the Previous and Next links (NOTE:localgov_base.themestill does this),guidesbehavior javascript for efficiencyHow to test
#lgd-guides__title, and not#lgd-guides__title#lgd-guides__title#lgd-guides__titleHow can we measure success?
This should return the Prev/Next links to a slightly more accessible condition: the fragments in the URLs will refer to elements that exist on the page and so can be focused, aiding keyboard navigation for users.
Have we considered potential risks?
n/a
Images
Before
After
Accessibility
(The second two items don't apply to this change).