8000 Add custom attributes for prev-next component by markconroy · Pull Request #768 · localgovdrupal/localgov_base · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add custom attributes for prev-next component #768

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

markconroy
Copy link
Member

Closes #758

What does this change?

Adds a custom attribute for prev-next component, so other attributes (like node classes) don't pollute it.

How to test

Embed the prev-next component in a node template. Check that the classes are:

<nav class="node node--type-page lgd-prev-next">...</nav>

Now, check out this branch and check the classes now DO NOT have the node classes in the nav:

<nav class="lgd-prev-next">...</nav>

@markconroy markconroy requested a review from ctorgalson April 23, 2025 14:54
Copy link
Contributor
@ctorgalson ctorgalson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me 👍

@markconroy markconroy merged commit ceebe58 into 1.x Apr 23, 2025
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling prev-next SDC from inside a node template gives duplicate classes
2 participants
0