1.8.7 release #720
Merged
1.8.7 release #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: adds, uses new variable icon_fullpath The new variable uses icon_path alone if it begins with '@' (i.e. if it's Twig-namespaced), but will use the value of theme (defaulting to 'localgov_base') in other circumstances. * feat: adds documentation for the 'theme' variable Variable was present but unused, and undocumented outside of code comments. * feat: adds default value for undefined icon_path variable This is the path that's used in localgov_base. * feat: replaces variable assignmemt, use with in-place string derivation Nothing actually changes but that we have three fewer lines of variable assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.