-
Notifications
You must be signed in to change notification settings - Fork 2
sets news blocks to appear in sidebar_first #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve this as it is more consistent at least!
Discussing in Merge Tuesday, it is a bit odd having the search block and filters on the LHS on the full node view. Directories and Events do not follow this pattern. Shall we: a) remove the blocks from the full node? BHCC keep the search and facets on the RHS: https://www.brighton-hove.gov.uk/news @msayoung @markconroy thoughts? |
gov.uk https://www.gov.uk/search/news-and-communications has filters on overview only, and no filters on the news article itself |
I had a look through a few sites over the last few days, seems most of them are not putting a sidebar on news pages, only on the news listing page/search page. So it might be good to remove the sidebar from news pages (as we do for other content types). |
Rather than tinker with news, I'd like us to move to the Sheffield and Dumfries layout created by @clearspotmedia and executed by Rohallion. Also copying @dedavidson to check if this is OK |
@willguv is that this layout: |
@markconroy the new layouts for Sheffield and Dumfries and Galloway are not live yet. |
I could share the Figma links for the layouts, but it's probably easier to look at the real thing on a dev or live site with Dan Champion's theming work. |
@willguv suggests we check in with Dave Hampton (@clearspotmedia) on the latest thinking with regards to best practice UX. |
@clearspotmedia we were discussing consistent placement of search and facet blocks across news, events and directories at Merge Tuesday today
As the designer who's looked at this most recently (with Dumfries and Sheffield news) it would be great to get the benefit of your expertise. Cheers! |
My approach is typically search and filters sit to the left or above the results they are returning. News articles are a slight anomaly. |
Really helpful, thanks @clearspotmedia. Copying @msayoung @finnlewis @markconroy so we can chat about an approach |
Following the comments from @msayoung @markconroy @clearspotmedia above, is the consistent pattern to remove the sidebar from news articles? If councils want to add it, we ought to make it easy for them to do so |
@willguv the pages for Dumfries are live now. Sheffield uses the same layout. I'm not sure this helps answer your question, as it's a leap from out the box layout, but here's my latest approach in more detail with links: News landing page News archive (search results) News article The UI includes a condensed search and filter component with category pills, for a more condensed design. |
Closes #126
What does this change?
Sets the news filter blocks to appear in
sidebar_first
instead ofsidebar_second
.Thanks to Big Blue Door for sponsoring my time to work on this.