8000 sets news blocks to appear in sidebar_first by markconroy · Pull Request #131 · localgovdrupal/localgov_news · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sets news blocks to appear in sidebar_first #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

markconroy
Copy link
Member

Closes #126

What does this change?

Sets the news filter blocks to appear in sidebar_first instead of sidebar_second.


Thanks to Big Blue Door for sponsoring my time to work on this.

@finnlewis finnlewis self-requested a review December 10, 2024 11:48
@finnlewis finnlewis self-assigned this Dec 10, 2024
@finnlewis
Copy link
Member

Does what it says on the tin, but now the full news article page feels a bit odd with the search and filters on the first sidebar:

image

@finnlewis finnlewis requested a review from msayoung December 10, 2024 11:58
Copy link
Member
@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this as it is more consistent at least!

@finnlewis
Copy link
Member
finnlewis commented Dec 10, 2024

Discussing in Merge Tuesday, it is a bit odd having the search block and filters on the LHS on the full node view.

Directories and Events do not follow this pattern.

Shall we:

a) remove the blocks from the full node?
b) move the search and facets to the RHS like BHCC ?

BHCC keep the search and facets on the RHS:

https://www.brighton-hove.gov.uk/news

@msayoung @markconroy thoughts?

@millnut
Copy link
Member
millnut commented Dec 10, 2024

gov.uk https://www.gov.uk/search/news-and-communications has filters on overview only, and no filters on the news article itself

@markconroy
Copy link
Member Author

I had a look through a few sites over the last few days, seems most of them are not putting a sidebar on news pages, only on the news listing page/search page. So it might be good to remove the sidebar from news pages (as we do for other content types).

@willguv
Copy link
Member
willguv commented Dec 13, 2024

Rather than tinker with news, I'd like us to move to the Sheffield and Dumfries layout created by @clearspotmedia and executed by Rohallion. Also copying @dedavidson to check if this is OK

@markconroy
Copy link
Member Author

@dedavidson
Copy link

@markconroy the new layouts for Sheffield and Dumfries and Galloway are not live yet.

@clearspotmedia
Copy link

I could share the Figma links for the layouts, but it's probably easier to look at the real thing on a dev or live site with Dan Champion's theming work.

@finnlewis
Copy link
Member

@willguv suggests we check in with Dave Hampton (@clearspotmedia) on the latest thinking with regards to best practice UX.

@finnlewis finnlewis assigned willguv and unassigned finnlewis Jan 7, 2025
@willguv
Copy link
Member
willguv commented Jan 7, 2025

@clearspotmedia we were discussing consistent placement of search and facet blocks across news, events and directories at Merge Tuesday today

As the designer who's looked at this most recently (with Dumfries and Sheffield news) it would be great to get the benefit of your expertise. Cheers!

@clearspotmedia
Copy link

@willguv

My approach is typically search and filters sit to the left or above the results they are returning.
That would apply to news, directory, event landing pages.

News articles are a slight anomaly.
At Dumfries and Sheffield, we intentionally placed the news search and category pills in the right sidebar.
Making it secondary to the news article content.
Reason - we want to lead with the news article headline, standfirst and image visible on the page.
Search and filters can take up the whole or most of the screen on mobile, losing the impact of the article format.

@willguv
Copy link
Member
willguv commented Jan 7, 2025

Really helpful, thanks @clearspotmedia. Copying @msayoung @finnlewis @markconroy so we can chat about an approach

@ekes ekes marked this pull request as draft January 14, 2025 12:12
@willguv
Copy link
Member
willguv commented Jan 14, 2025

Following the comments from @msayoung @markconroy @clearspotmedia above, is the consistent pattern to remove the sidebar from news articles?

If councils want to add it, we ought to make it easy for them to do so

@clearspotmedia
Copy link

@willguv the pages for Dumfries are live now. Sheffield uses the same layout.

I'm not sure this helps answer your question, as it's a leap from out the box layout, but here's my latest approach in more detail with links:

News landing page
https://www.dumfriesandgalloway.gov.uk/news
Featured news grid = Full width
Below that
Search and filter = Left sidebar 33
News feed = Right col main 77

News archive (search results)
After searching or selecting categories
https://www.dumfriesandgalloway.gov.uk/news/search?f%5B0%5D=category%3A27
Search and filter = Left sidebar 33
News feed = Right col main 77

News article
https://www.dumfriesandgalloway.gov.uk/news/2024/garden-waste-collection-service-permit-applications-open
Article hero area = Full width
Search and filter = Left sidebar 33
News feed = Right col main 77

The UI includes a condensed search and filter component with category pills, for a more condensed design.
As mentioned previously, we kept search in the right sidebar on the article intentionally so it is secondary to the article content visually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search block and facets block placement changes depending on which page you are on (UX)
6 participants
0