8000 Add and enable Live Preview module to Microsites by finnlewis · Pull Request #505 · localgovdrupal/localgov_microsites · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add and enable Live Preview module to Microsites #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Add and enable Live Preview module to Microsites #505

wants to merge 2 commits into from

Conversation

finnlewis
Copy link
Member

No description provided.

Copilot
Copilot AI reviewed Mar 27, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds live preview functionality to microsites by introducing a new dependency.

  • Added dependency for the live preview feature in the localgov_microsites.info.yml file.
Files not reviewed (1)
  • composer.json: Language not supported

@finnlewis finnlewis requested a review from stephen-cox March 27, 2025 12:41
@finnlewis finnlewis mentioned this pull request Mar 27, 2025
Open
@finnlewis
Copy link
Member Author

See #455 also.

markconroy
markconroy previously approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member
@markconroy markconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine, installed live_preview modules, but there were no permissions set.

I presume that's just because the permissions PR hasn't been merged yet.

@ekes
Copy link
Member
ekes commented Apr 1, 2025

I still haven't resolved the questions I asked in the chat:-

  • Why is this two modules? The parent module only supplies the permission required by the child module.
  • The permission is only used once on access to a route that is a redirect. So is permission 'See link to' rather than 'Use'? I assume the routes redirected to have access control, could it be the same?

@markconroy
Copy link
Member

@ekes It's two modules because I plan on creating code for localgov_base in the parent module (accent colours, etc), and then only code that is relevant to localgov_microsites in the sub module.

@finnlewis
Copy link
Member Author

Discussing in Merge Tuesday:

@ekes is asking about the permissions. See: localgovdrupal/localgov_live_preview#15

We want to tidy up the permissions before we add localgov_live_preview to the install.

@finnlewis
Copy link
Member Author

Note: might be good to test accessibility, keyboard navigation for example.

@stephen-cox stephen-cox changed the title Feature/455 live preview Add and enable Live Preview module to Microsites Apr 1, 2025
stephen-cox
stephen-cox reviewed Apr 1, 2025
View reviewed changes
Copy link
Member
@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works pretty well. I found a couple of issues with the media handling, one which I think is reasonably serious (localgovdrupal/localgov_live_preview#18), but happy to discuss whether it is serious enough to block this.

@finnlewis
Copy link
Member Author

Let's keep this open for now... see:

localgovdrupal/localgov_live_preview#21

localgovdrupal/localgov_live_preview#19

@finnlewis finnlewis requested a review from markconroy April 8, 2025 11:49
@markconroy markconroy dismissed their stale review April 8, 2025 11:49

Dismissing until we add more features.

@finnlewis
Copy link
Member Author

Let's keep this open for now... see:

localgovdrupal/localgov_live_preview#21

localgovdrupal/localgov_live_preview#19

These two are merged, so we're just looking at the accessibility review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-cox stephen-cox stephen-cox left review comments

Copilot code review Copilot Copilot left review comments

@ekes ekes Awaiting requested review from ekes

@markconroy markconroy Awaiting requested review from markconroy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@finnlewis @ekes @markconroy @stephen-cox
0