introduce baseurl and remove force_https #1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1549 +/- ##
==========================================
- Coverage 46.87% 46.87% -0.01%
==========================================
Files 48 48
Lines 6841 6842 +1
==========================================
Hits 3207 3207
- Misses 3634 3635 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
callebtc
reviewed
Feb 28, 2023
callebtc
reviewed
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDEA: introduce BASEURL variable like other webapplications also have
this PR introduces the settings variable
LNBITS_BASEURLthis makes generating URLs on the serverside much easier for developers.
you do not need to rely on a request object anymore to create an absolute URL,
for example for all the lnurl stuff, server startup log/superuser urls, etc...
the obvious downside is that users need to introduce a new variable if they are behind a proxy.
but i think it is tradeoff worth taking, because this will reduce the overall complexity of the code
and also simplyfies generating proper url for other developers aswell.
also gets rid of
LNBITS_FORCE_HTTPSvariable, because it is not used anymore.