8000 Hide the not-yet-implemented file handling APIs by ncoghlan · Pull Request #81 · lmstudio-ai/lmstudio-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hide the not-yet-implemented file handling APIs #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

ncoghlan
Copy link
Collaborator

When the image preparation APIs were added to the server API, the general purpose file preparation APIs were also incorrectly marked as public in the client SDK API.

Having those APIs available suggests that adding other file types (text files, PDFs, etc) to the chat context via the SDK is expected to work, when that simply isn't true (yet).

When the image preparation APIs were added to the server API,
the general purpose file preparation APIs were also incorrectly
marked as public in the client SDK API.

Having those APIs available suggests that adding other file types
(text files, PDFs, etc) to the chat context via the SDK is expected
to work, when that simply isn't true (yet).
@github-actions github-actions bot added the CLA signed Indicates that all contributors have signed label Apr 24, 2025
@ncoghlan ncoghlan merged commit 53bacd6 into main Apr 24, 2025
10 checks passed
@ncoghlan ncoghlan deleted the hide-nyi-files-api branch April 24, 2025 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA signed Indicates that all contributors have signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0