8000 fix vimto exec for binaries in /tmp by lmb · Pull Request #15 · lmb/vimto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix vimto exec for binaries in /tmp #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2024
Merged

fix vimto exec for binaries in /tmp #15

merged 3 commits into from
May 17, 2024

Conversation

lmb
Copy link
Owner
@lmb lmb commented May 17, 2024 •
edited
Loading

fix vimto exec for binaries in /tmp

vimto exec fails for binaries in /tmp, because I introduced a bug into the
shared directory code. This didn't trigger a failure in CI because we use a
TMPDIR which is a subdirectory of the current working directory.

Add a script helper which allocates a new TMPDIR and fix the bug.

fix incorrect TMPDIR in VM

The VM currently inherits TMPDIR from the host environment. This doesn't
make sense since we set up our own /tmp. Fix this by clearing TMPDIR and
ensuring that /tmp is world writable.

only print warning on EACCES

There is a heuristic which is meant to warn the user if the VM doesn't have
read access to a file residing on 9pfs. Currently it also prints out the
same warning if the file doesn't exist.

Only print the warning if we get EACCES.

lmb added 3 commits May 17, 2024 09:25
@lmb
fix vimto exec for binaries in /tmp
28aa603 
vimto exec fails for binaries in /tmp, because I introduced a bug
into the shared directory code. This didn't trigger a failure in CI
because we use a TMPDIR which is a subdirectory of the current
working directory.

Add a script helper which allocates a new TMPDIR and fix the bug.
@lmb
fix incorrect TMPDIR in VM
a01c641 
The VM currently inherits TMPDIR from the host environment. This
doesn't make sense since we set up our own /tmp. Fix this by clearing
TMPDIR and ensuring that /tmp is world writable.
@lmb
only print warning on EACCES
0f2e799 
There is a heuristic which is meant to warn the user if the VM
doesn't have read access to a file residing on 9pfs. Currently it
also prints out the same warning if the file doesn't exist.

Only print the warning if we get EACCES.
@lmb lmb merged commit 066f340 into main May 17, 2024
4 checks passed
@lmb lmb deleted the fix-exec-bug branch May 17, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lmb
0