8000 [lit-next] Adds `labs` package by sorvell · Pull Request #1390 · lit/lit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[lit-next] Adds labs package #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 30, 2020
Merged

[lit-next] Adds labs package #1390

merged 15 commits into from
Oct 30, 2020

Conversation

sorvell
Copy link
Member
@sorvell sorvell commented Oct 26, 2020

The labs package is an experimental playground for Lit helpers and tools.

Steven Orvell added 6 commits October 20, 2020 10:56
This provides the foundation onto which element controllers that hook into element lifecycle can be built. Note, this adds 0.05K gzipped.
The `labs` package is an experimental playground for Lit helpers and tools.
@github-actions
Copy link
Contributor
github-actions bot commented Oct 26, 2020

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -7% - +2% (-2.57ms - +0.63ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -2% - +3% (-2.14ms - +2.60ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -5% - +14% (-2.11ms - +5.94ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +5% (-0.23ms - +0.68ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-2.03ms - +1.01ms)
    this-change vs tip-of-tree
  • updating-element-list: unsure 🔍 -1% - +4% (-0.43ms - +2.02ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -2% - +1% (-21.19ms - +7.39ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-2.19ms - +5.17ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +1% (-10.02ms - +5.33ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +0% (-5.84ms - +0.67ms)
    this-change vs tip-of-tree
  • updating-element-list: unsure 🔍 -3% - +1% (-4.00ms - +1.69ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -2% - +1% (-20.42ms - +15.35ms)
    this-change vs tip-of-tree
  • updating-element-list: unsure 🔍 -3% - +1% (-5.17ms - +2.20ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
102.11ms - 105.09ms-unsure 🔍
-2% - +3%
-2.14ms - +2.60ms
faster ✔
21% - 24%
28.22ms - 32.86ms
tip-of-tree
tip-of-tree
101.53ms - 105.22msunsure 🔍
-3% - +2%
-2.60ms - +2.14ms
-faster ✔
21% - 25%
28.21ms - 33.32ms
previous-release
previous-release
132.36ms - 135.91msslower ❌
27% - 32%
28.22ms - 32.86ms
slower ❌
27% - 33%
28.21ms - 33.32ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
920.50ms - 938.76ms-unsure 🔍
-2% - +1%
-21.19ms - +7.39ms
faster ✔
7% - 10%
74.67ms - 102.68ms
tip-of-tree
tip-of-tree
925.54ms - 947.53msunsure 🔍
-1% - +2%
-7.39ms - +21.19ms
-faster ✔
7% - 9%
66.49ms - 97.06ms
previous-release
previous-release
1007.69ms - 1028.93msslower ❌
8% - 11%
74.67ms - 102.68ms
slower ❌
7% - 10%
66.49ms - 97.06ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1025.45ms - 1051.81ms-unsure 🔍
-2% - +1%
-20.42ms - +15.35ms
faster ✔
2% - 6%
23.08ms - 61.34ms
tip-of-tree
tip-of-tree
1029.07ms - 1053.26msunsure 🔍
-1% - +2%
-15.35ms - +20.42ms
-faster ✔
2% - 5%
21.27ms - 58.07ms
previous-release
previous-release
1066.97ms - 1094.70msslower ❌
2% - 6%
23.08ms - 61.34ms
slower ❌
2% - 6%
21.27ms - 58.07ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
39.54ms - 47.21ms-unsure 🔍
-5% - +14%
-2.11ms - +5.94ms
faster ✔
11% - 25%
5.54ms - 13.47ms
tip-of-tree
tip-of-tree
40.25ms - 42.67msunsure 🔍
-13% - +4%
-5.94ms - +2.11ms
-faster ✔
19% - 24%
9.84ms - 13.00ms
previous-release
previous-release
51.86ms - 53.90msslower ❌
11% - 33%
5.54ms - 13.47ms
slower ❌
23% - 32%
9.84ms - 13.00ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
105.43ms - 109.65ms-unsure 🔍
-2% - +5%
-2.19ms - +5.17ms
unsure 🔍
-2% - +4%
-1.87ms - +4.47ms
tip-of-tree
tip-of-tree
103.03ms - 109.06msunsure 🔍
-5% - +2%
-5.17ms - +2.19ms
-unsure 🔍
-4% - +3%
-4.02ms - +3.64ms
previous-release
previous-release
103.87ms - 108.60msunsure 🔍
-4% - +2%
-4.47ms - +1.87ms
unsure 🔍
-3% - +4%
-3.64ms - +4.02ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
35.86ms - 37.82ms-unsure 🔍
-7% - +2%
-2.57ms - +0.63ms
faster ✔
3% - 13%
0.91ms - 5.25ms
tip-of-tree
tip-of-tree
36.55ms - 39.08msunsure 🔍
-2% - +7%
-0.63ms - +2.57ms
-unsure 🔍
-11% - +0%
-4.42ms - +0.20ms
previous-release
previous-release
37.99ms - 41.85msslower ❌
2% - 14%
0.91ms - 5.25ms
unsure 🔍
-1% - +12%
-0.20ms - +4.42ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.92ms - 13.59ms-unsure 🔍
-2% - +5%
-0.23ms - +0.68ms
faster ✔
14% - 20%
2.25ms - 3.24ms
tip-of-tree
tip-of-tree
12.72ms - 13.34msunsure 🔍
-5% - +2%
-0.68ms - +0.23ms
-faster ✔
16% - 21%
2.49ms - 3.45ms
previous-release
previous-release
15.63ms - 16.36msslower ❌
17% - 25%
2.25ms - 3.24ms
slower ❌
19% - 27%
2.49ms - 3.45ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
399.33ms - 411.41ms-unsure 🔍
-2% - +1%
-10.02ms - +5.33ms
faster ✔
31% - 34%
187.16ms - 206.18ms
tip-of-tree
tip-of-tree
402.97ms - 412.46msunsure 🔍
-1% - +2%
-5.33ms - +10.02ms
-faster ✔
31% - 33%
185.58ms - 203.07ms
previous-release
previous-release
594.69ms - 609.38msslower ❌
46% - 51%
187.16ms - 206.18ms
slower ❌
45% - 50%
185.58ms - 203.07ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
70.72ms - 72.75ms-unsure 🔍
-3% - +1%
-2.03ms - +1.01ms
faster ✔
14% - 18%
12.25ms - 15.75ms
tip-of-tree
tip-of-tree
71.12ms - 73.38msunsure 🔍
-1% - +3%
-1.01ms - +2.03ms
-faster ✔
14% - 18%
11.66ms - 15.31ms
previous-release
previous-release
84.30ms - 87.16msslower ❌
17% - 22%
12.25ms - 15.75ms
slower ❌
16% - 21%
11.66ms - 15.31ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
144.01ms - 148.59ms-unsure 🔍
-4% - +0%
-5.84ms - +0.67ms
faster ✔
14% - 18%
24.09ms - 31.32ms
tip-of-tree
tip-of-tree
146.57ms - 151.20msunsure 🔍
-0% - +4%
-0.67ms - +5.84ms
-faster ✔
13% - 16%
21.49ms - 28.75ms
previous-release
previous-release
171.21ms - 176.80msslower ❌
16% - 22%
24.09ms - 31.32ms
slower ❌
14% - 19%
21.49ms - 28.75ms
-
updating-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.66ms - 56.34ms-unsure 🔍
-1% - +4%
-0.43ms - +2.02ms
unsure 🔍
-3% - +3%
-1.65ms - +1.83ms
tip-of-tree
tip-of-tree
53.82ms - 55.59msunsure 🔍
-4% - +1%
-2.02ms - +0.43ms
-unsure 🔍
-4% - +2%
-2.46ms - +1.05ms
previous-release
previous-release
53.89ms - 56.93msunsure 🔍
-3% - +3%
-1.83ms - +1.65ms
unsure 🔍
-2% - +5%
-1.05ms - +2.46ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
125.44ms - 129.41ms-unsure 🔍
-3% - +1%
-4.00ms - +1.69ms
unsure 🔍
-2% - +2%
-2.32ms - +3.10ms
tip-of-tree
tip-of-tree
126.55ms - 130.62msunsure 🔍
-1% - +3%
-1.69ms - +4.00ms
-unsure 🔍
-1% - +3%
-1.20ms - +4.30ms
previous-release
previous-release
125.19ms - 128.88msunsure 🔍
-2% - +2%
-3.10ms - +2.32ms
unsure 🔍
-3% - +1%
-4.30ms - +1.20ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
191.28ms - 196.11ms-unsure 🔍
-3% - +1%
-5.17ms - +2.20ms
unsure 🔍
-3% - +1%
-5.68ms - +1.51ms
tip-of-tree
tip-of-tree
192.40ms - 197.96msunsure 🔍
-1% - +3%
-2.20ms - +5.17ms
-unsure 🔍
-2% - +2%
-4.45ms - +3.25ms
previous-release
previous-release
193.12ms - 198.44msunsure 🔍
-1% - +3%
-1.51ms - +5.68ms
unsure 🔍
-2% - +2%
-3.25ms - +4.45ms
-

tachometer-reporter-action v2 for Benchmarks


These features may change significantly and frequently, or they may be
removed altogether. In some cases, when a feature stabilizes and proves to be
useful, it may move into the core Lit library.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"it may move into one of the core Lit packages or a new package"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

From inside your project folder, run:

```bash
$ npm install lit-labs 8000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the right package name? may we update later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added TODO

$ npm install lit-labs
```

## Supported Browsers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to leave browser support to individual libraries

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

* Code distributed by Google as part of the polymer project is also
* subject to an additional IP rights grant found at
* http://polymer.github.io/PATENTS.txt
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want an export {} for various tools that use that to detect module format, and maybe a console.log("there's nothing here") too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

8000
* http://polymer.github.io/PATENTS.txt
*/

let count = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove until it's needed?

@sorvell sorvell merged commit 677d5fe into lit-next Oct 30, 2020
@sorvell sorvell deleted the lit-next-labs branch October 30, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0