[lit-html] Add the `until` directive. #1389

bicknellr · 2020-10-24T01:51:18Z

Fixes #1356. ~~A few of the old tests are broken currently: some seem related to timing and others seem related to EventParts.~~

This PR also changes lit-html itself in a few ways:

Directives that are associated with an AttributePart are now passed their index in the AttributePart's values array.
setPartValue now takes an index when setting an AttributePart's value.

Fix lit-element import paths For now, build template-shadowroot as part of lit-ssr Add lit-ssr tests to CI Fix merge error (Template:_options) Remove tsconfig.tsbuildinfo Uncomment element tests ffrom server-only suite Fix return value of createRenderRoot patch

Rename $litPrivate -> $private Fix demo hydration README updates

Some minor cleanup included

Co-authored-by: Abdón Rodríguez Davila <a@abdonrd.com>

Rename Directive:resolve -> _resolve Add comments

…ously in both `render` and `update`.

bicknellr · 2020-10-28T01:30:38Z

I merged lit-next-ssr and made it the base branch of this PR, but lit-next-ssr hasn't merged lit-next recently, so this PR's diff against it currently includes #1370 and possibly other changes.

`_state` maps parts to the last set of values provided to a directive and the index of the last value from that list that was rendered. It needs to be an instance property because the mapping between parts and directives is not always one-to-one. Particularly, for interpolated AttributeParts, the mapping can be one-to-many, which can cause the multiple directives associated with that single part to overwrite each other's state if they key only by the associated part.

…Value override

…tring is logged.

kevinpschaaf

LGTM

kevinpschaaf · 2020-11-13T07:49:15Z

Oh one more tiny thing, please update the README to remove until from the list of unimplemented directives.

…and CHANGELOG.

bicknellr · 2020-11-13T21:20:35Z

Ok, updated. I also found that it was listed as removed in the CHANGELOG so I removed that. I'll merge once the tests pass.

kevinpschaaf and others added 30 commits October 15, 2020 16:13

Initial SSR commit (code copied from #hydration & lit-ssr)

938459a

Initial lit-html rendering/hydration (element tests disabled)

370344e

Add private-ssr-support to lit-html for re-exporting private symbols

e895d31

Cleanup & update README

51d6a58

Rename $litPrivate -> $private Fix demo hydration README updates

Add renderLight directive

3797d58

Disable incremental compilation for now

b3c0d39

Update ssr code to new lint rules

1036e3b

Some minor cleanup included

Format all and fix formatting errors

acd3914

Remove format script from lit-ssr package.json

a4255d8

Co-authored-by: Abdón Rodríguez Davila <a@abdonrd.com>

Cleanup package.json

fa21d91

Add a strawman for files to publish

768d82a

Add test from PolymerLabs/lit-ssr#63

553f9cc

Remove only from test

eab2f7b

Add pacakge to README

3cfc91a

Add hydrate-support.js to exports

444854d

Add TODOs for async directives

c441141

Update comment to avoid it being specific to LitElement

0dcbf21

Remove seemingly unnecessary export

9e12144

Add comments

17012a7

Review feedback

105a411

Rename Directive:resolve -> _resolve Add comments

Make _start/_endNode @internal

0d61dfe

Remove prettier config from package

d6de4c2

Fix code sample to match text

85bfcda

Remove dirty-check; use elementStyles

562d25e

Add todo/issue for reflecting attributes

2298953

Add 'koa-' prefix to middleware module name

8000 01b09c6

Fix comment, remove duplication.

8cb53a0

Cleanup

3495105

Address more review feedback

8cc26f5

bicknellr added 2 commits October 27, 2020 17:57

Update old until to use the new directive API.

021a487

Use the same code to determine if a value should be rendered synchron…

4e0088b

…ously in both `render` and `update`.

bicknellr changed the base branch from lit-next to lit-next-ssr October 28, 2020 01:27

bicknellr and others added 6 commits October 28, 2020 12:03

Add a deprecation warning for until in dev-mode.

3839977

Revert _resolveValue factoring (had perf impact); use optional commit…

961e95c

…Value override

Downgrade Chrome for time being

3fc59a1

Try the other direction with Chrome

c7163e0

Merge remote-tracking branch 'origin/lit-next-ssr' into lit-next-until

54d8287

Base automatically changed from lit-next-ssr to lit-next October 30, 2020 16:29

bicknellr added 4 commits October 30, 2020 16:18

Merge remote-tracking branch 'origin/lit-next' into lit-next-until

8520c14

Remove local polyfill dependency in tests.

7321a8a

Combine old and new until tests.

b20aa9a

Prevent filterBrowserLogs from throwing if something other than a s…

7f4ab01

…tring is logged.

bicknellr marked this pull request as ready for review October 31, 2020 00:34

bicknellr requested a review from justinfagnani as a code owner October 31, 2020 00:34

Revert optional chaining in EventPart.

4a36ed5

bicknellr requested review from sorvell and kevinpschaaf October 31, 2020 00:41

bicknellr added 2 commits November 2, 2020 15:43

Merge remote-tracking branch 'origin/lit-next' into lit-next-until

687ccf5

Merge remote-tracking branch 'origin/lit-next' into lit-next-until

cb98377

bicknellr added the lit-next label Nov 10, 2020

kevinpschaaf approved these changes Nov 12, 2020

View reviewed changes

bicknellr added 2 commits November 13, 2020 13:17

Remove until from the list of unsupported directives in the README …

816dd2c

…and CHANGELOG.

Merge remote-tracking branch 'origin/lit-next' into lit-next-until

35ae6d8

bicknellr merged commit df72b38 into lit-next Nov 13, 2020

bicknellr deleted the lit-next-until branch November 13, 2020 22:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lit-html] Add the `until` directive. #1389

[lit-html] Add the `until` directive. #1389

[lit-html] Add the until directive. #1389

[lit-html] Add the until directive. #1389

Conversation

Choose a reason for hiding this comment

[lit-html] Add the `until` directive. #1389

[lit-html] Add the `until` directive. #1389