[#2732] Increase margin on badges #2942
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add {# djlint:off #} to component library as this is hand coded html,
not representing the component code strictly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added margin to the bottom of the badges, this increases the space below.
#2732
I considered refactoring the code to be flexbox (example), but decided it touched too many components I'm unsure how to test. Should refactering it be on our technical backlog? As the current solution adds space even when the row is not wrapped.
I also added {# djlint:off #} to component library to mute linting, as this is hand coded html, not representing the component code strictly. Another task for the technical backlog might be building a component library that uses our components in situe, so they are representative of our code as it changes.
Tasks