8000 Improve accessibility of dashboard tabs (issue #2171) by artyfakt · Pull Request #2937 · liqd/adhocracy-plus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve accessibility of dashboard tabs (issue #2171) #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve accessibility of dashboard tabs (issue #2171) #2937

wants to merge 1 commit into from

Conversation

artyfakt
Copy link

I'm currently familiarizing myself with a4/a+ and thought I would try working on some open issue 8000 s in the process. To start off, I had a stab at #2171.

  • since dashboard tabs load new pages (instead of revealing some hidden content on the same page), I found that applying Bootstrap's built-in tab functionality doesn't work
  • instead I added some javascript that can be loaded via the extra_js block in the django template
  • the script ensures keyboard navigability in line with ARIA recommendations for tabs with manual activation (Press tab to enter the tablist, press directional keys to navigate the tablist, press enter to activate a tab)
  • for the script to work, the tablist needs to have the class "dashboard-tabs" and the role="tablist"
  • also each tab of the tablist needs to have the role="tab"

I'm happy to work more on this according to your feedback. Also, let me know if there are any other good first issues (preferably frontend-heavy).

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@t-j-q
Copy link
Contributor
t-j-q commented Jun 2, 2025

Hello @artyfakt thank you for contributing! I'm sorry that we hadn't have time to get back to you- we are quite occupied currently. Maybe @shn-liqd or @partizipation could have a look?

Best wishes from Berlin
Tietje

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artyfakt @t-j-q @JonasCodeworks
0