-
Notifications
You must be signed in to change notification settings - Fork 123
Metrics: changed port from 8080 to 8082 #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
/rebase test=true |
08d96b4
to
4e7ec9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grepping for 8080, I see some deployments templates to still have 8080 as metric port
4e7ec9c
to
72207ec
Compare
/rebase test=true |
@cheina97 this is probably breaking something since both tests (overlapped and not) are broken while waiting for the connection to be set up in the peer command |
72207ec
to
f8b1002
Compare
/build |
f8b1002
to
b868016
Compare
/rebase test=true |
1 similar comment
/rebase test=true |
/build |
/rebase test=true |
b868016
to
c9c7fae
Compare
/rebase test=true |
1 similar comment
/rebase test=true |
b80647c
to
3b01983
Compare
/rebase test=true |
/merge |
Description
This PR changes the ports used for metrics from 8080 to 8082. This is useful to avoid using port 8080 with host network pods, as port 8080 should be used by another service on the host.