8000 Metrics: changed port from 8080 to 8082 by cheina97 · Pull Request #2818 · liqotech/liqo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Metrics: changed port from 8080 to 8082 #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

cheina97
Copy link
Member

Description

This PR changes the ports used for metrics from 8080 to 8082. This is useful to avoid using port 8080 with host network pods, as port 8080 should be used by another service on the host.

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/rebase test=true

Copy link
Member
@fra98 fra98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grepping for 8080, I see some deployments templates to still have 8080 as metric port

@cheina97
Copy link
Member Author

/rebase test=true

@aleoli
Copy link
Member
aleoli commented Nov 21, 2024

@cheina97 this is probably breaking something since both tests (overlapped and not) are broken while waiting for the connection to be set up in the peer command

@cheina97
Copy link
Member Author

/build

@cheina97
Copy link
Member Author

/rebase test=true

1 similar comment
@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author
cheina97 commented Dec 5, 2024

/build

@cheina97
Copy link
Member Author
cheina97 commented Dec 5, 2024

/rebase test=true

8000

@cheina97
Copy link
Member Author
cheina97 commented Dec 5, 2024

/rebase test=true

1 similar comment
@cheina97
Copy link
Member Author
cheina97 commented Dec 5, 2024

/rebase test=true

@cheina97
Copy link
Member Author
cheina97 commented Dec 5, 2024

/rebase test=true

@cheina97
Copy link
Member Author
cheina97 commented Dec 5, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 5, 2024
@adamjensenbot adamjensenbot merged commit 10ef308 i 7B13 nto liqotech:master Dec 5, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0