8000 fix: retrieve GatewayServer/GatewayClient resources by labels by fra98 · Pull Request #2758 · liqotech/liqo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: retrieve GatewayServer/GatewayClient resources by labels #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: retrieve GatewayServer/GatewayClient resources by labels #2758

merged 1 commit into from
Oct 8, 2024

Conversation

fra98
Copy link
Member
@fra98 fra98 commented Oct 4, 2024

Description

This PR fixes a bug in Liqoctl where GatewayServer and GatewayClient resources were retrieved by name instead of labels.

@fra98 fra98 added the kind/bug label Oct 4, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/get-gw-by-labels branch from b00b020 to 5104d19 Compare October 4, 2024 12:30
@fra98 fra98 changed the title bug: retrieve GatewayServer/GatewayClient resources by labels fix: retrieve GatewayServer/GatewayClient resources by labels Oct 4, 2024
@fra98 fra98 force-pushed the frt/get-gw-by-labels branch from 5104d19 to a142b34 Compare October 4, 2024 12:45
@fra98 fra98 force-pushed the frt/get-gw-by-labels branch 2 times, most recently from d7112f1 to b806fde Compare October 7, 2024 15:38
@fra98
Copy link
Member Author
fra98 commented Oct 8, 2024

/rebase test=true

@fra98
Copy link
Member Author
fra98 commented Oct 8, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 8, 2024
@adamjensenbot adamjensenbot merged commit 89c8ce7 into liqotech:master Oct 8, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli
0