8000 [Feat] New In-Band Peering by aleoli · Pull Request #2720 · liqotech/liqo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feat] New In-Band Peering #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2024
Merged

[Feat] New In-Band Peering #2720

merged 3 commits into from
Sep 11, 2024

Conversation

aleoli
Copy link
Member
@aleoli aleoli commented Sep 6, 2024 •
edited
Loading

Description

This pr fixes the support for API server proxies and the in-band peering

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author
aleoli commented Sep 6, 2024

/build

1 similar comment
@aleoli
Copy link
Member Author
aleoli commented Sep 6, 2024

/build

@aleoli
Copy link
Member Author
aleoli commented Sep 6, 2024

/test

@aleoli aleoli marked this pull request as ready for review September 6, 2024 13:55
@aleoli aleoli requested review from cheina97 and fra98 September 6, 2024 13:55
frisso
frisso reviewed Sep 8, 2024
View reviewed changes
frisso
frisso reviewed Sep 8, 2024
View reviewed changes
frisso
frisso reviewed Sep 9, 2024
View reviewed changes
frisso
frisso reviewed Sep 9, 2024
View reviewed changes
frisso
frisso reviewed Sep 9, 2024
View reviewed changes
@frisso
Copy link
Member
frisso commented Sep 9, 2024

@aleoli All fine for me. Just added 3 small rephrasing, if you're ok.
8000

@aleoli
Copy link
Member Author
aleoli commented Sep 9, 2024

Thanks @frisso! I fixed them

@cheina97
Copy link
Member

/build

cheina97
cheina97 reviewed Sep 10, 2024
View reviewed changes
fra98
fra98 approved these changes Sep 10, 2024
View reviewed changes
@aleoli
Copy link
Member Author
aleoli commented Sep 11, 2024

/test

@cheina97
Copy link
Member

/rebase test=true

@aleoli
Copy link
Member Author
aleoli commented Sep 11, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 11, 2024
@adamjensenbot adamjensenbot merged commit 4992cda into liqotech:master Sep 11, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

@frisso frisso frisso approved these changes

@fra98 fra98 fra98 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleoli @adamjensenbot @frisso @cheina97 @fra98
0