8000 Avoid retrieval of tenant namespace by name by fra98 · Pull Request #2703 · liqotech/liqo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid retrieval of tenant namespace by name #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

Avoid retrieval of tenant namespace by name #2703

merged 1 commit into from
Aug 28, 2024

Conversation

fra98
Copy link
Member
@fra98 fra98 commented Aug 20, 2024

Description

This PR refactors some liqoctl commands to not rely on the metadata name to retrieve a tenant namespace. Retrieval by naming is unsafe as tenant namespace names can be customized and one should rely only on labels to retrieve the correct tenant namespace.

The PR makes the function that generates the default tenant namespace name private and modifies liqoctl commands to only rely on the NamespaceManager interface to retrieve the correct namespace.

@fra98 fra98 added the kind/bug label Aug 20, 2024
@pull-request-size pull-request-size bot added t 8000 he size/M label Aug 20, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/liqoctl-get-gateways branch from 32bb624 to d4cc4a4 Compare August 21, 2024 12:39
@fra98 fra98 requested a review from aleoli August 21, 2024 12:42
@fra98 fra98 force-pushed the frt/liqoctl-get-gateways branch from d4cc4a4 to ec6755f Compare August 21, 2024 12:44
@fra98
Copy link
Member Author
fra98 commented Aug 21, 2024

/test

@fra98
Copy link
Member Author
fra98 commented Aug 22, 2024

/test

@fra98
Copy link
Member Author
fra98 commented Aug 28, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/liqoctl-get-gateways branch from ec6755f to 592030f Compare August 28, 2024 12:25
@fra98
Copy link
Member Author
fra98 commented Aug 28, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 28, 2024
@adamjensenbot adamjensenbot merged commit 76e4f85 into liqotech:master Aug 28, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli
0