feat(cli-vector): New cli to create mbtiles for vector map. BM-1268 #3435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccbblin
reviewed
Apr 30, 2025
| for (const feature of features) { | ||
| writeStream.write(JSON.stringify(feature) + '\n'); | ||
| } | ||
| writeStream.close(); |
There was a problem hiding this comment.
I'm getting FATAL Command:Failed err={ type=Error message=Tippecanoe Docker failed to run stack=Error: Tippecanoe Docker failed to run. I think you need to wait for the writeStream to finish here, something like
await new Promise((resolve) => {
writeStream.close(resolve);
});
ccbblin
reviewed
May 5, 2025
| minzoom: simplify.style.minZoom, | ||
| maxzoom: simplify.style.maxZoom, | ||
| }; | ||
| if (simplify.tolerance != null) { |
There was a problem hiding this comment.
needed feature.geometry != null
ccbblin
reviewed
May 5, 2025
| const feature = tag(options, line, s); | ||
| if (feature == null) continue; | ||
| outputCount++; | ||
| features.push(JSON.parse(feature) as VectorGeoFeature); |
There was a problem hiding this comment.
can we writeStream.write(feature + '\n'); instead of storing it in memory, hitting some oom errors when running locally
Wentao-Kuang
commented
May 20, 2025
| @@ -0,0 +1,31 @@ | |||
| FROM node:20-slim as builder | |||
There was a problem hiding this comment.
This is just temporary file that I copy here as reference, we will move all the installs and ENV into package/cli Dockerfile later. Then test the vector cli in the cli container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Verification