8000 nemo-view.c: fix crash after some shortcuts by jknockel · Pull Request #3525 · linuxmint/nemo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

nemo-view.c: fix crash after some shortcuts #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

jknockel
Copy link
Contributor
@jknockel jknockel commented Feb 5, 2025

On action_follow_symlink_callback() and
action_open_containing_folder_callback() we now confirm that exactly one thing is selected. Previously, if zero things were selected, we would segfault.

On action_follow_symlink_callback() and
action_open_containing_folder_callback() we now confirm that exactly one
thing is selected.  Previously, if zero things were selected, we would
segfault.
@mtwebster
Copy link
Member

Hi, how do you reproduce the crash? These two menu items shouldn't be available if there's nothing selected (checked in real_update_menus).

@jknockel
Copy link
Contributor Author

I found this crash originally when I had accidentally typed ctrl+alt+o instead of ctrl+alt+l trying to lock my screen, which triggered action_open_containing_folder_callback() on my focused nemo window. However, looking at the nemo code, I don't see a keyboard shortcut for action_follow_symlink_callback(), so I don't remember if I had originally added the check to that function purely defensively or if I had somehow found a way to trigger it.

@mtwebster mtwebster merged commit a98a467 into linuxmint:master Mar 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0