8000 web-google-chat by tony1661 · Pull Request #466 · linuxmint/mint-y-icons · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

web-google-chat #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

< 8000 /div>
Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

web-google-chat #466

wants to merge 6 commits into from

Conversation

tony1661
Copy link

Adding icon for web-google-chat

@Hokiper
Copy link
Contributor
Hokiper commented Apr 18, 2025

I think the centralization could be improved here.
My suggestion would be to do something like this (I took the orignal image from the app's official icon on Google Play):
image

Also, it helps if you generate the bitmaps for the icons you make by running src/render-apps-categories-bitmaps.py and include them in the pull request. Remember to close all instances of Inkscape before running the script, otherwise you may end up with a bunch of windows.

I also suggest adding the following symbolic links to your icon:
GoogleChat-chat.google.com.png
google-chat.png

For that, you just have to add the following lines to src/symbolic-apps-list and run src/create-symbolic-link-from-list.py
image

@Hokiper
Copy link
Contributor
Hokiper commented Apr 18, 2025

You also need to unhide the Baseplate layer, edit the icon-name with the text tool so it matches the icon's name, and hide the Baseplate layer again. The script to generate the bitmaps won't work if the names don't match.
image

@tony1661
Copy link
Author

Thank you @Hokiper for considering my contribution and for your assistance. I will make those changes.

Question: is there a guide I can follow going forward? I've contributed to Delta Icons before and they have a contribution guide that may help noobs like me 😅

@Hokiper
Copy link
Contributor
Hokiper commented Apr 18, 2025 •
edited
Loading

There's no written set of contribution guidelines, although this is actually something that has been talked about a few times - I even offered to make one myself.
The main discouragement for writing something like that (for me at least, since that's why I haven't made it myself yet) is that there's some uncertainty about if the Mint-Y icon theme will still be the default in the near future.

@Hokiper
Copy link
Contributor
Hokiper commented Apr 18, 2025

But now that you mentioned it I'll bring that up with Clem just to see if he's still interested. If positive I should be making one on May's last week or so.

@mtwebster
Copy link
Member

Hi, please run src/render-apps-categories-bitmaps.py (and correct any errors it reports), and add the generated png files to this PR.

Thanks

@tony1661
Copy link
Author
tony1661 commented May 28, 2025 •
edited
Loading

Hi @Hokiper I have made the requested changes. Let me know if they are ok. if not I can adjust.

Hi @mtwebster I ran the script you mentioned and here is the

$ ./render-apps-categories-bitmaps.py

Rendering from SVGs in ./apps

apps web-google-chat web-google-chat

** (org.inkscape.Inkscape:175224): WARNING **: 17:54:04.562: Can't open file: /home/tfernandez/.config/inkscape/cphistory.xml (doesn't exist)
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat
apps web-google-chat web-google-chat


Rendering from SVGs in ./categories

@Hokiper
Copy link
Contributor
Hokiper commented May 28, 2025

Hi @Hokiper I have made the requested changes. Let me know if they are ok. if not I can adjust.

They look alright to me.

@tony1661
Copy link
Author

Hi Team, just checking in if there are any other changes to be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tony1661 @Hokiper @mtwebster
0