feature(inject): introduce PatchProducer abstraction
#14175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
adleong
reviewed
Jun 27, 2025
|
|
||
| // PatchProducer is a function that generates a patch for a given resource configuration | ||
| // and OverriddenValues. | ||
| type PatchProducer func(conf *ResourceConfig, injectProxy bool, values *OverriddenValues, patchPathPrefix string) ([]byte, error) |
There was a problem hiding this comment.
If the return type here was JSONPatch instead of []byte, would that save some marshalling/unmarshalling?
|
|
||
| // ValueOverrider is used to override the default values that are used in chart rendering based | ||
| // on the annotations provided in overrides. | ||
| type ValueOverrider func(values *l5dcharts.Values, overrides map[string]string, namedPorts map[string]int32) (*OverriddenValues, error) |
There was a problem hiding this comment.
What do you think about making the return type here just map[string]interface{}? It simplifies things by getting rid of having both Values and Additional. On the other hand, setting things like PodInboundPorts and ClusterNetworks into an untyped nested map is less ergonomic so I'm not sure if it's better..... what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
PatchProducerabstraction. This allows to abstract away the creation of proxy injection patches and to potentially layer multiple patches on top of each other.Signed-off-by: Zahari Dichev zaharidichev@gmail.com