8000 Fix grpc handling of trailers-only h2 responses · Pull Request #2379 · linkerd/linkerd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix grpc handling of trailers-only h2 responses #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Fix grpc handling of trailers-only h2 responses #2379

merged 1 commit into from
Mar 24, 2020

Conversation

ghost
Copy link
@ghost ghost commented Mar 18, 2020

No description provided.

@ghost ghost requested review from adleong, olix0r and zaharidichev as code owners March 18, 2020 14:32
@jlawrie
Fix grpc handling of trailers-only h2 responses
a51c97a 
Signed-off-by: James Lawrie <james.lawrie@nytimes.com>
@ghost ghost force-pushed the grpc-trailers-only-fix branch from bcade23 to a51c97a Compare March 18, 2020 14:33
@ghost
Copy link
Author
ghost commented Mar 18, 2020

Fixes #2378

@cpretzer
Copy link
Contributor

Thank you @jlawrienyt, this is really helpful.

Will take a look and get this PR merged after all the checks pass.

adleong
adleong approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member
@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @jlawrienyt! This looks correct to me. ⭐

zaharidichev
zaharidichev approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member
@zaharidichev zaharidichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Bonus points for the test!

@adleong adleong merged commit 3e64562 into linkerd:master Mar 24, 2020
@adleong adleong mentioned this pull request Mar 24, 2020
Closed
2 tasks
@ghost ghost deleted the grpc-trailers-only-fix branch March 25, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r Awaiting requested review from olix0r olix0r is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpretzer @adleong @zaharidichev @jlawrie
0