Fix replicasAssignment Hashmap #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78d1700 to
04f7a53
Compare
zigarn
approved these changes
Feb 10, 2021
|
With the current code we have a simple random sampling with replacement, which has no sense for a replica assignment. |
|
Any chance to see this reviewed and integrated? @andrewchoi5 @Lincong? |
andrewchoi5
reviewed
Apr 12, 2021
andrewchoi5
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a fix for the issue #325. (Closed but not solved).
When creating a ClusterTopicManipulationService topic, the constructor uses a Hasmap containing the brokers id for each replica partition.
The problem is that has it is, the same broker id can be repeated.
With this fix, a simple shuffle of the brokers allows a random repartition of the brokers ids.
No need for the while loop.
Thanks