Change trino-parser dependency to compileOnly (coral issue#205) #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trino regression tests passed |
funcheetah
approved these changes
Jan 20, 2022
|
spark regressions tests passed |
wmoustafa
approved these changes
Jan 20, 2022
This was referenced Jan 20, 2022
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary fix to unblock issue coral #205
Shading trino-parser was done, however, it causes some IDEs (IntelliJ in particular) to not recognize trino-parser libraries, which makes the experience contributing to Coral suboptimal. With compileOnly/implementation, issue #205 is unblocked and we are to revisit all shading in Coral in the near future.