-
Notifications
You must be signed in to change notification settings - Fork 197
Revert all shading trino-parser commits #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8803fc3
to
cdb2571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a revert? Can we link to another commit/PR that is being reverted?
cdb2571
to
c70e99a
Compare
According to the code change, I don't think it's the revert of these 2 commits. |
@wmoustafa @ljfgem the diff seems to match that the "Merge branch 'master' into master" commit made these changes
|
trino regression tests introduced one new unrelated failure |
c70e99a
to
b083f15
Compare
coral-spark/src/main/java/com/linkedin/coral/spark/TransportableUDFMap.java
Outdated
Show resolved
Hide resolved
b083f15
to
3c9d169
Compare
Did this change since I see the UDF changes are no longer part of the PR? |
yes, I updated the PR and I reverted 2 commits only (skipped reverting the "merge Master into master" commit |
Thanks! Will merge after integration tests. |
iTests succeeded (Trino failed with unrelated error after successfully translating all views) |
sycn with upstream