Adding support for defaults from EnumSymbols #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating fields with the FieldBuilder and supplying a default value to the field builder by using the adapter's genericDefaultValue from an existing field, it will return a `GenericData.EnumSymbol`. This changeset makes Jackson1Utils `GenericData.EnumSymbol` aware.
radai-rosenblatt
approved these changes
Aug 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
============================================
+ Coverage 25.10% 25.12% +0.01%
- Complexity 1144 1145 +1
============================================
Files 188 188
Lines 14839 14842 +3
Branches 2276 2277 +1
============================================
+ Hits 3726 3729 +3
Misses 10672 10672
Partials 441 441
Continue to review full report at Codecov.
|
flowenol
pushed a commit
to RTBHOUSE/avro-util
that referenced
this pull request
Aug 23, 2023
When creating fields with the FieldBuilder and supplying a default value to the field builder by using the adapter's genericDefaultValue from an existing field, it will return a `GenericData.EnumSymbol`. This changeset makes Jackson1Utils `GenericData.EnumSymbol` aware. Co-authored-by: Christopher Harris <chharris@chharris-mn2.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating fields with the FieldBuilder and supplying a default
value to the field builder by using the adapter's genericDefaultValue
from an existing field, it will return a
GenericData.EnumSymbol.This changeset makes Jackson1Utils
GenericData.EnumSymbolaware.