Implement Image::from_peniko_image
#996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenzV
approved these changes
May 8, 2025
sparse_strips/vello_api/src/paint.rs
Outdated
| /// This panics if `image` has a `width` or `height` greater than `u16::MAX`. | ||
| pub fn from_peniko_image(image: &peniko::Image) -> Self { | ||
| if image.format != peniko::ImageFormat::Rgba8 { | ||
| unimplemented!("Unsupported image format: {:?}", image.format); |
There was a problem hiding this comment.
Can't we return an Option instead and return None in this case?
There was a problem hiding this comment.
I'm a bit torn. I think we do ideally have a non-fallible function for this and we should try to make sure to support all the Peniko image formats (currently there's only Rgba8). Perhaps peniko::ImageFormat growing should be considered breaking, not least because there's no existing mechanism in Peniko to convert it to something known.
There was a problem hiding this comment.
(Vello Classic also has infallible methods taking Image (through Brush), https://docs.rs/vello/0.5.0/vello/struct.Scene.html#method.fill).
Probably a temporary method until there's better resource binding; in the meantime this is useful for clients already using `Peniko::Image`. Perhaps `Pixmap` should get a method to do the conversion to premultiplied RGBA8 from `&[Rgba8]`, or perhaps `Vec<Rgba8>` using Bytemuck with the `extern_crate_alloc` feature (though the latter doesn't help with `Peniko::Image`, which stores data in an `Arc`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a temporary method until there's better resource binding; in the meantime this is useful for clients already using
Peniko::Image.Perhaps
Pixmapshould get a method to do the conversion to premultiplied RGBA8 from&[Rgba8], or perhapsVec<Rgba8>using Bytemuck with theextern_crate_allocfeature (though the latter doesn't help withPeniko::Image, which stores data in anArc).