Remove hack for tolerance of stroke expansion #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cubic-to-cubic stroke expansion is still technically dependent on the scale factor, but the sensitivity is greatly less than when lowering to lines. Thus, it should be possible to retain stroke-expanded paths over a fairly wide range of scale factors. I don't have my head completely around whether it's a good idea to merge this. |
|
The main reason I wanted to remove it is because it's causing trouble with transforms where the scaling factor is close to 0 and the skewing factor is instead pretty large. But maybe we need to come up with a more principled approach here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was needed in the initial prototype for
vello_cpuwhere we were using the stroke expansion implementation of the GPU stroke expansion paper, which approximates the stroke by line segments. We had to adjust the tolerance here, because if you draw a small stroke which is then scaled up, you can very clearly notice the line approximation.However, the current (and future) kurbo stroke do cubic-to-cubic stroke expansion, so I don't think this should be necessary here?