8000 Add snapshot tests for image_extend_modes test scenes by sagudev · Pull Request #973 · linebender/vello · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add snapshot tests for image_extend_modes test scenes #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Add snapshot tests for image_extend_modes test scenes #973

merged 1 commit into from
May 7, 2025

Conversation

sagudev
Copy link
Contributor
@sagudev sagudev commented May 7, 2025

They will be needed for fixing #972.

@sagudev
Add snapshot tests for image_extend_modes test scenes
81a7172 
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev
Copy link
Contributor Author
sagudev commented May 7, 2025

Is there any reason why all test scenes do not have snapshot tests?

@DJMcNab
Copy link
Member
DJMcNab commented May 7, 2025

For image extend mode specifically, we disabled them in #766, because we weren't getting consistent results cross-platform. I don't know why that is no longer applying.

My best guess for the other test sce 8000 nes not being there is sloth - I got bored partway through adding them.

DJMcNab
DJMcNab approved these changes May 7, 2025
View reviewed changes
Copy link
Member
@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense to have, even with the known deficiencies.

vello_tests/snapshots/image_extend_modes_nearest_neighbor.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bleedover pixel on the left edge of the right pictures is the reason we didn't add these before.

@DJMcNab DJMcNab added this pull request to the merge queue May 7, 2025
Merged via the queue into linebender:main with commit 9241215 May 7, 2025
17 checks passed
@sagudev sagudev deleted the extend-scenes branch May 7, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagudev @DJMcNab
0