10000 Fix erroneous agm_elliptic_perimeter if radius y > radius x by tomcur · Pull Request #407 · linebender/kurbo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix erroneous agm_elliptic_perimeter if radius y > radius x #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

Fix erroneous agm_elliptic_perimeter if radius y > radius x #407

merged 1 commit into from
Feb 9, 2025

Conversation

tomcur
Copy link
Member
@tomcur tomcur commented Dec 13, 2024

I noticed this while working on the numeric approximation of the Arc perimeter. This doesn't (or doesn't easily?) occur for Ellipse, as it instead gets a rotation when constructed with radius y > radius x.

@tomcur
Fix erroneous agm_elliptic_perimeter if radius y > radius x
41f3dff 
I noticed this while making a numeric approximation of the `Arc`
perimeter. This doesn't (or doesn't easily?) occur for `Ellipse`, as
they get a rotation when constructed with radius y > radius x.
@tomcur tomcur added this pull request to the merge queue Feb 9, 2025
Merged via the queue into linebender:main with commit 4982e13 Feb 9, 2025
15 checks passed
@tomcur tomcur deleted the fix-radius branch February 9, 2025 09:34
@DJMcNab DJMcNab mentioned this pull request Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneem jneem jneem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomcur @jneem
0