Fixing misleading operators #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d41338c to
d18cb18
Compare
In the filter feature of the silence list form, the =~ operator caused confusion as users thought they could use regex. However, only values ending in * are regex, others are considered literals. Therefore, for the sake of avoiding confusion among our users, we change the UI to use the = operator. It is better to put an = operator in there until we add support for new operators in the future. We know this is not 100% accurate, because anything ending in * is considered a regular expression, therefore the actual operation is =~ in that case. We also change a misleading comment in the code that led to the addition of the =~ operator in the UI.
…list of silence Currently, when using the filter feature on the global list of silence, we are using the === operator in JavaScript. The values being compared are also entirely chosen from a list of specific values. Therefore, the operator that should be displayed here is = instead of =~. We have made this change to avoid misunderstandings.
997cd4a to
721120b
Compare
vincent-olivert-riera
approved these changes
Mar 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some filters on UI that have confused users by displaying the =~ operator instead of =. We will change it.
The silence create modal:
BEFORE:
AFTER:
The global list of silence:
BEFORE:
AFTER:
