bug: ENG-17965 - fix language code mapping #26
Conversation
Add Language code mapper
There was a problem hiding this comment.
LGTM.
it might be worth adding some more mappings in there that we know will be a problem later. for example i think we should probably add in all of these number mappings in now.
we have to publish new versions of the plugin and users have to upgrade to get the changes so might as well put some more mappings in there now rather than needing to republish again later.
|
@mkante-lilt one other question i have here is why this "Remote Language Mapping" option doesn't work in this case? in theory this should allow us to map things the way we want. if there is a bug in that implementation maybe it is worth fixing that instead. |
|
@tgallant I didn't find a Drupal equivalent code name for those languages you mentioned |
There was a problem hiding this comment.
@mkante-lilt sounds good. i think we can keep it like this for now then. after this PR is merged we will have to follow these steps to publish a new release https://github.com/lilt/lilt_drupal_env?tab=readme-ov-file#creating-releases
| @@ -18,6 +18,10 @@ | |||
| use Symfony\Component\DependencyInjection\ContainerInterface; | |||
| use Symfony\Component\HttpFoundation\RedirectResponse; | |||
|
|
|||
| const DRUPAL_LANG_FILTER_MAP = [ | |||
| 'zh' => 'zt', // drupal language code ===> Lilt language code | |||
There was a problem hiding this comment.
@vvdanila @mkante-lilt i believe the issue is that we are switching simplified to traditional, so this update will make it so that only traditional memories will be show now
so it looks like this fixed being able to select traditional memories (original ticket) the new ticket is that we no longer can select simplified
i think the way to go is to show both, lilt zh and zt memories instead (or see if we can do the actual mapping with LILT codes)
Add Language code mapper for Drupal code
zhto Lilt codezt