Lazy oracle unit tests #1192
Open
Lazy oracle unit tests #1192
+677
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: ad33d44 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
dry914
reviewed
Jul 3, 2025
| context("sanity params", () => { | ||
| it("update quarantine period", async () => { | ||
| await lazyOracle.grantRole(await lazyOracle.UPDATE_SANITY_PARAMS_ROLE(), deployer.address); | ||
| await lazyOracle.updateSanityParams(250000n, 1000n); |
There was a problem hiding this comment.
I think it would be useful to add test case when address without UPDATE_SANITY_PARAMS_ROLE tries to call updateSanityParams function (with revert).
| vaultReport3[3], | ||
| vaultReport3[4], | ||
| tree3.getProof(0), | ||
| ); |
There was a problem hiding this comment.
Here we can check QuarantinedDeposit event
| vaultReport4[3], | ||
| vaultReport4[4], | ||
| tree4.getProof(0), | ||
| ); |
There was a problem hiding this comment.
Here we can check QuarantineExpired event
| }); | ||
|
|
||
| context("handleSanityChecks", () => { | ||
| it("limit", async () => { |
There was a problem hiding this comment.
I think it would be valuable to add test for this logic:
some percentage of funds hasn't passed through the vault's balance is allowed for the EL and CL rewards handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy oracle unit tests (batch and count)