Implement parsing of MS OS 1.0 descriptors #1631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XUSB can now parse MS OS 1.0 descriptors if it detects that device signals their presence. The code attempts to do some basic checking of integrity of the payload of descriptors so developers can use xusb to check the basic sanity of descriptors in their device.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
examples/xusb.c:832
- The boundary check for the extended property descriptor may not correctly account for the layout of multiple extended property records. Consider reviewing the pointer arithmetic to ensure that it accurately verifies the full descriptor length.
if (property_desc != ((uint8_t *) descriptor + len))
|
Lets start with fixing the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XUSB can now parse MS OS 1.0 descriptors if it detects that device signals their presence.
The code attempts to do some basic checking of integrity of the payload of descriptors so developers can use xusb to check the basic sanity of descriptors in their device.