feat(legacy): make autoloading playlist autofill lead time configurable #3176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-for-autoload-lookahead-time
|
I'm going to need somebody with perms to re-run the failing check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autoloading playlists ruin cache ahead time. In the playout service it is hard coded to be 1 day, but if you make heavy use of autoloading playlists, in reality it is only 1 hour ahead.
This is a new feature:
Yes
I have updated the documentation to reflect these changes:
Yes
Testing Notes
What I did:
I set the time to an invalid interval and saw the expected error message pop up. I then configured a lead time of 5 days and created a show 2 days out. I then visited the
/api/invalidendpoint to get tasks to trigger and saw my show had been scheduled.How you can replicate my testing:
See what I did section.
Links
Closes #3174