8000 fix(installer): clarify install documentation around specifying a non-default port by HighTechHarmony · Pull Request #3126 · libretime/libretime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(installer): clarify install documentation around specifying a non-default port #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HighTechHarmony
Copy link
Contributor

Description

In the Admin Manual section dealing with running the installer and specifying a port other than the default, there was some incongruity in how the public URL should be specified. The port needs to be provided both as an argument to --listen-port as well in the public URL. In particular, when used as shown, one of the examples as previously written would lead to the API not being able to start after an otherwise successful installation run, causing confusion.

Testing Notes

I tested the example as shown in the updated installation document, and the system (including the API) was able to start successfully.

Links

Closes: #3113

@HighTechHarmony HighTechHarmony changed the title fix(docs): clarify install documentation around specifying a non-default port fix(installer): clarify install documentation around specifying a non-default port Dec 16, 2024
@paddatrapper
Copy link
Contributor

Are you testing this with a non-default client-facing port or is the non-default port only behind the reverse proxy?

@HighTechHarmony
Copy link
Contributor Author

Are you testing this with a non-default client-facing port or is the non-default port only behind the reverse proxy?

Behind the reverse proxy, the part where the port is specified in a 8000 rgument(s) to the installer (or via env). Without specifying the port in both places, the API will not even be able to start.

@paddatrapper
Copy link
Contributor

Hmm... Then this configuration is going to produce broken user-facing links in things like emails. The actual issue is that the API should not be using the public_url to connect to the service. A work around is to allow it to correctly connect to your reverse proxy. In Docker we fixed this by overriding the LIBRETIME_GENERAL_PUBLIC_URL passed to the API container:

LIBRETIME_GENERAL_PUBLIC_URL: http://nginx:8080

@HighTechHarmony
Copy link
Contributor Author

Hmm... Then this configuration is going to produce broken user-facing links in things like emails. The actual issue is that the API should not be using the public_url to connect to the service. A work around is to allow it to correctly connect to your reverse proxy. In Docker we fixed this by overriding the LIBRETIME_GENERAL_PUBLIC_URL passed to the API container

Heard; I think the main part of this issue is that the documentation is a little lean at best (misleading at worst?), for someone trying to set up on a non-standard port without a reverse proxy. Then. if it's misconfigured, the resulting API startup issue is a bit tricky to troubleshoot, as there is no easy indication that this is what the problem is, and how to fix it. The Troubleshooting section offers some tips on viewing log files from each service, but in this case the API seems to fail before it starts logging, and the web interface returns a 503, so there is not much to go on.

What would have helped me is a paragraph discussing alternative ports, where there are URL and port config settings that need to be considered (with examples), and something indicating that this can result in the API not starting up, for those who are searching the docs for answers. An separate paragraph would also be good to cover the specifics of configuring for docker, that you pointed out.

@paddatrapper
Copy link
Contributor

What about including such a section or tutorial instead? Talk about how to configure things and what parts of the install need to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New deployment: API service won't start after correctly following official installation procedure when specifying alt. port
2 participants
0