perf: optimize the api image health check #3038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running curl every 30s is much more efficient that running python to make a single http call
jooola
reviewed
Jun 22, 2024
|
Thanks! |
jooola
pushed a commit
that referenced
this pull request
Jun 22, 2024
🤖 I have created a release *beep* *boop* --- ## [4.2.0](4.1.0...4.2.0) (2024-06-22) ### Features * **legacy:** add current date macro to string block criteria ([#3013](#3013)) ([451652b](451652b)) * **legacy:** add filename block criteria ([#3015](#3015)) ([4642b6c](4642b6c)) ### Bug Fixes * pin pip version to <24.1 to allow installing pytz (celery) ([#3043](#3043)) ([646bc81](646bc81)) * playlist allocates inaccurate time to smartblocks ([#3026](#3026)) ([2b43e51](2b43e51)) ### Performance Improvements * optimize the api image health check ([#3038](#3038)) ([d99d6e1](d99d6e1)) * optimize the rabbitmq health check ([#3037](#3037)) ([9684214](9684214)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
<
622C
/div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having curl installed in the API container improves operations and the efficiency of the health check. Launching python to do a single http call is an overkill.
This is a new feature:
No
I have updated the documentation to reflect these changes:
Not necessary
Testing Notes
What I did:
Compare cpu time of the new health check command to the old health check command
How you can replicate my testing:
See above