8000 fix(legacy): replay_gain_modifier should be a system preference by jooola · Pull Request #2943 · libretime/libretime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(legacy): replay_gain_modifier should be a system preference #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(legacy): replay_gain_modifier should be a system preference #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fe96f3
fix(legacy): replay_gain_modifier is not a user preference
jooola Feb 8, 2024
68707ab
docs: wording
jooola Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/releases/unreleased.md
8000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ Please follow this **before the upgrade procedure**.

## :arrow_up: Upgrading

### Replay gain modifier preference

The `replay_gain_modifier` preference is now stored as system preference. Please check and save the replay gain modifier preference manually to make sure the preference is up to date and usable.

## :warning: Known issues

The following issues may need a workaround for the time being. Please search the [issues](https://github.com/libretime/libretime/issues) before reporting problems not listed below.
Expand Down
2 changes: 1 addition & 1 deletion legacy/application/models/Preference.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ public static function getReplayGainModifier()

public static function setReplayGainModifier($rg_modifier)
{
self::setValue('replay_gain_modifier', $rg_modifier, true);
self::setValue('replay_gain_modifier', $rg_modifier, false);
}

public static function SetHistoryItemTemplate($value)
Expand Down
0