feat: use custom intro/outro playlists per show #2941
Conversation
|
Remark: this was an absolute nightmare to implent through all layers and abstractions. I full heartedly support ditching the legacy UI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
===========================================
+ Coverage 70.36% 93.65% +23.28%
===========================================
Files 149 95 -54
Lines 4033 1498 -2535
===========================================
- Hits 2838 1403 -1435
+ Misses 1195 95 -1100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0495f7b to
a62f74d
Compare
5e1fb08 to
743d143
Compare
7dc68b6 to
c1fc5dd
Compare
|
Have you tested this with smartblocks? Is there any chances that the final show length is way of because didn't account for the added intro/outro duration? Or was this already implemented in the initial work for the global intro/outro? |
ff5d83b to
c50d865
Compare
This is already implemented in the existing logic. This PR just swaps out the ID's of the intro and outro playlist before processing if a custom one is defined. The only real change needed for this feature is the one in |
a855619 to
b229232
Compare
b229232 to
ba4d879
Compare
|
Is there something required on my side to get this moving again? :-) I know it's a huge patch but most of this is database changes to add the two fields to store the info, partly auto-generated. UI looks like this after the change (unused parts are folded away) |
|
@paddatrapper docs added and a minor fix to the screen display. I forgot the checkboxes from my screenshot were gone with a mod, so only the dropdowns remain. This change clarifies that 'None' means 'take the default from the global settings'. Updated screenshot: |
🤖 I have created a release *beep* *boop* --- ## [4.3.0](4.2.0...4.3.0) (2025-03-12) ### Features * add flac support to Web player ([#3128](#3128)) ([203c927](203c927)) * add Norwegian Bokmål locale ([#3073](#3073)) ([e614fbc](e614fbc)) * **analyzer:** parse comment fields from mp3 files ([#3082](#3082)) ([02a779b](02a779b)) * **api:** added filters on genre & md5 for files api ([#3127](#3127)) ([b1bdd6d](b1bdd6d)) * **api:** enable writes to schedule table ([#3109](#3109)) ([2ac7e8a](2ac7e8a)) * **legacy:** implement subset sum solution to show scheduling ([#3019](#3019)) ([5b5c68c](5b5c68c)), closes [#3018](#3018) * **legacy:** order by filename when lptime is null ([#3069](#3069)) ([8c26505](8c26505)) * **legacy:** show filename and size on edit page and add filename datatable column ([#3083](#3083)) ([16deaf0](16deaf0)), closes [#3053](#3053) * **legacy:** trused header sso auth ([#3095](#3095)) ([2985d85](2985d85)) * **legacy:** update deprecated PHP code ([#2789](#2789)) ([3a8dcbc](3a8dcbc)) * **playout:** add Liquidsoap 2.0 support ([#2786](#2786)) ([f9c0bd5](f9c0bd5)) * use custom intro/outro playlists per show ([#2941](#2941)) ([299be3c](299be3c)) ### Bug Fixes * add missing file for nb_NO locale ([#3075](#3075)) ([a3865aa](a3865aa)) * **analyzer:** make ffmpeg filters less aggressive ([#3086](#3086)) ([32cad0f](32cad0f)), closes [#2629](#2629) * docker warnings "keywords casing do not match" ([#3048](#3048)) ([e095cb2](e095cb2)) * intro/outro playlist unset was impossible ([#3101](#3101)) ([7992a9b](7992a9b)) * **legacy:** additional specifics added to CSVexport.js for RFC 4180 ([#3131](#3131)) ([644d2b9](644d2b9)), closes [#2477](#2477) * **legacy:** fix filename criteria searching ([#3068](#3068)) ([c883d0f](c883d0f)) * **legacy:** migrations from airtime 2.5.1 ([#3123](#3123)) ([82d5af2](82d5af2)) * **legacy:** support Postgresql 12 syntax ([#3103](#3103)) ([0b221f4](0b221f4)), closes [#3102](#3102) * **playout:** improve the way hashlib is called in libretime_playout/player ([#3135](#3135)) ([5b4c720](5b4c720)), closes [#3134](#3134) * regenerate API schema ([38a0bf9](38a0bf9)) * regenerate API schema ([ce257a1](ce257a1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
Having a global intro and outro playlist in settings is not very flexible for special programming. This adds an override intro/outro playlist per show. If it is not set, the global one is used. also it's ignored if there's no autloading at all.
I have updated the documentation to reflect these changes:
...not yet, but i will.
Testing Notes
What I did:
Schedule 2 shows, one without defining custom lists, one with defining custom lists. one hour before the show starts it should be populated correctly. If you define a global list it shojuld be replaced with the per-show list.