8000 feat(deps): bullseye to bookworm docker install and test by mp3butcher · Pull Request #2898 · libretime/libretime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(deps): bullseye to bookworm docker install and test #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat(deps): bullseye to bookworm docker install and test #2898

wants to merge 14 commits into from

Conversation

mp3butcher
Copy link
Contributor
@mp3butcher mp3butcher commented Jan 15, 2024 •
edited
Loading

Description

Working stuff for docker liquidsoap 2.1 and php 8.1:

@codecov Codecov
Copy link
codecov bot commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (95283ef) 70.35% compared to head (3ccc558) 69.87%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
- Coverage   70.35%   69.87%   -0.49%     
==========================================
  Files         149      147       -2     
  Lines        4034     3943      -91     
==========================================
- Hits         2838     2755      -83     
+ Misses       1196     1188       -8
Flag Coverage Δ
playout 47.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mp3butcher mp3butcher changed the title Ubuntu22.04 docker php 8.1 docker Jan 15, 2024
@mp3butcher mp3butcher changed the title php 8.1 docker bulleye to bookworm docker file Jan 15, 2024
@mp3butcher mp3butcher changed the title bulleye to bookworm docker file feat(chore):bullseye to bookworm docker file Jan 16, 2024
@mp3butcher mp3butcher changed the title feat(chore):bullseye to bookworm docker file feat(chore): bullseye to bookworm docker file Jan 16, 2024
@mp3butcher mp3butcher changed the title feat(chore): bullseye to bookworm docker file feat(deps): bullseye to bookworm docker file Jan 16, 2024
@mp3butcher mp3butcher changed the title feat(deps): bullseye to bookworm docker file feat(deps): bullseye to bookworm docker files Jan 17, 2024
@mp3butcher mp3butcher changed the title feat(deps): bullseye to bookworm docker files feat(deps): bullseye to bookworm docker install and test Jan 17, 2024
@mp3butcher
Copy link
Contributor Author
mp3butcher commented Jan 21, 2024 •
edited
Loading

it seems there's a problem with liquidsoap 2.1
in ls_lib.liq function input.http
The autostart parameter is not yet implemented, then liquidsoap tries to open server socket on http://dummy/url and fails.
It works though but there's a repeated error message in logs..
savonet/liquidsoap#1674

@jooola
Copy link
Contributor
jooola commented Jan 22, 2024

Ideally, I would spawn a new input.http every time we start a new webstream. Not sure why this was implemented this way, but the code is from 6~10 years ago, so I assume liquidsoap improved greatly since then.

jooola
jooola reviewed Jan 22, 2024
View reviewed changes
Dockerfile
@@ -2,7 +2,7 @@ ARG LIBRETIME_VERSION
#======================================================================================#
# Python Builder #
#======================================================================================#
FROM python:3.10-slim-bullseye as python-builder
FROM python:3.10-slim-bookworm as python-builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The worker still uses Celery 4, which isn't compatible with Python 3.11.

This would require us to upgrade Celery to v5 and update the celery PHP library to match the new protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooola jooola jooola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mp3butcher @jooola @fuzfuz
0