8000 Bug when trying to edit tacks · Issue #2000 · libretime/libretime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bug when trying to edit tacks #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Guillarda opened this issue Jul 26, 2022 · 7 comments · Fixed by #2003
Closed

Bug when trying to edit tacks #2000

Guillarda opened this issue Jul 26, 2022 · 7 comments · Fixed by #2003
Labels
is: bug

Comments

@Guillarda
Copy link

Describe the bug
When I want to change the metadata of a track and I save the metadata, the change does not apply and when I check the log, errors appear.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Tracks (in dashboard)
  2. Click on a track
  3. Click on a edit
  4. Edit metadata
  5. Click on save
  6. See error in file

LibreTime version:
Version: 3.0.0-alpha.13

Installation method:

Screenshots
https://imgur.com/q6XccZv

Client (please complete the following information if applicable):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 103.0.5060.134 (Build officiel) (64 bits)
@jooola
Copy link
Contributor
jooola commented Jul 26, 2022 •
edited
Loading

I could not reproduce this on bullseye, the file is saving as expected and no error is logged.

Could you please tell me:

  • which field you edited ?
  • if you have track types ?
  • if you upgraded from a previous version ?

@jooola
Copy link
Contributor
jooola commented Jul 26, 2022 •
edited
Loading

Yeaah it's ticket number #2000, this calls for celebration 🎉 haha !

@Guillarda
Copy link
Author
Guillarda commented Jul 26, 2022 •
edited
Loading

No matter which field I edit I always have this same problem

I don't have a track type

I didn't upgrade from an old version I just did a clean install

I want to add that I tried to install on Debian because I read that it worked better but when I launch the installer it does not work so I am on Ubuntu

@jooola
Copy link
Contributor
jooola commented Jul 26, 2022

I tried again on ubuntu 20.04 LTS, could not reproduce the error.

Please provide more details on the error your are facing and details about your installation. Maybe also the logs please (and please no screenshot, those aren't useful).

@jooola
Copy link
Contributor
jooola commented Jul 26, 2022

I reproduced it, I'll dig into this.

jooola added a commit to jooola/libretime that referenced this issue Jul 26, 2022
@jooola
fix(legacy): sanitize track_type_id when updating file
aa14ed4 
Fixes libretime#2000
jooola added a commit to jooola/libretime that referenced this issue Jul 26, 2022
@jooola
fix(legacy): sanitize track_type_id when updating file
f462a78 
Fixes libretime#2000
@jooola jooola mentioned this issue Jul 26, 2022
Merged
@Guillarda
Copy link
Author

Perfect, you've solved the problem
So to get it on my machine I have to wait for the next update I guess, right?

paddatrapper pushed a commit that referenced this issue Jul 27, 2022
@jooola
fix(legacy): sanitize track_type_id when updating file (#2003)
f137be0 
Fixes #2000
@jooola
Copy link
Contributor
jooola commented Jul 27, 2022

Perfect, you've solved the problem So to get it on my machine I have to wait for the next update I guess, right?

You either wait for the next release or cherry-pick the commit and apply it to your installation:

# Pull the latest changes
git checkout main
git pull

# Return to version 3.0.0-alpha.13 and apply the fix
git checkout 3.0.0-alpha.13
git cherry-pick f137be09a1b2b1509768fa50960f02dbb04edeb1

# And rerun the install script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(legacy): sanitize track_type_id when updating file jooola/libretime
2 participants
@jooola @Guillarda
0