8000 No longer `using namespace std;` and `using namespace Eigen;` to avoid issues with other libs by BruegelN · Pull Request #2481 · libigl/libigl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

No longer using namespace std; and using namespace Eigen; to avoid issues with other libs #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

No longer using namespace std; and using namespace Eigen; to avoid issues with other libs #2481

wants to merge 3 commits into from

Conversation

BruegelN
Copy link
Contributor

While using namespace std; and using namespace Eigen; was limited to function scope in libigl there have been a few issues where third-parties did not play nice with it.
I'm on par with @jdumas that's it's primarily the third-parties fault, however these issues keep popping up e.g.

Herby I propose to avoid using namespace std; and using namespace Eigen; completely in the sources of libigl.
For quality of live I did not touch tests or tutorials.

Checklist

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

@alecjacobson alecjacobson mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruegelN @alecjacobson
0