tests: remove test for strcasecmp #6691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strcasecmp is a posix function, testing it doesn't make sense. Functions that needs unsigned compare should use git__strcasecmp()
It was unused and only defined in posix.h It did not exist in its Windows equivalent.
|
This is one of those "what were we thinking!?" sort of moments. 🤔 And usually I can remember why we did something that seems silly five years down the line, but this one, I'm stumped. |
|
I'm guessing that this was just a "let's show that our strcasecmp works like the standard" but... that's obviously not the case in a world where strcasecmp is driven by locale (and we're not explicitly setting it to So... anyway, this all seems good to me. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strcasecmp is a posix function, testing it doesn't make sense.
Functions that needs unsigned compare should use git__strcasecmp()
If people are using signed chars then they will probably run into some issue where sorted strings end up in a different order but this is a problem with the functions calling strcasecmp instead of git__strcasecmp, not strcasecmp itself.