8000 1.54.0: gdisk/test-expand-gpt.pl fails · Issue #155 · libguestfs/libguestfs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

1.54.0: gdisk/test-expand-gpt.pl fails #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dvzrv opened this issue Oct 13, 2024 · 2 comments 8000
Open

1.54.0: gdisk/test-expand-gpt.pl fails #155

dvzrv opened this issue Oct 13, 2024 · 2 comments

Comments

@dvzrv
Copy link
dvzrv commented Oct 13, 2024

Hi! 👋

When trying to upgrade to 1.54.0, the gdisk/test-expand-gpt.pl test fails.

test-suite.log

I unfortunately don't understand why it fails or how to skip this test.
rwmjones added a commit that referenced this issue Oct 14, 2024
@rwmjones
tests/gdisk/test-expand-gpt.pl: Implement SKIP rule for this test
c25ff1a 
Reported-by: David Runge
Related: #155
@rwmjones
Copy link
Member

It is failing here:

libguestfs/tests/gdisk/test-expand-gpt.pl

Line 56 in 0edaea8

die unless $end_sectors <= 34;

although I'm not sure why.

Unfortunately there was no prior skip rule for this test, but I just implemented it in commit c25ff1a so now you can set:

export SKIP_TEST_EXPAND_GPT_PL=1

@dvzrv
Copy link
Author
dvzrv commented Nov 1, 2024

Thanks, skipping the test at least allowed me to build the updated package! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwmjones @dvzrv
0