Use IDWriteFontFallback when it is available #794
Conversation
IDWriteFontFallback is available on Windows 8.1 and more. There isn't any major advantage over the IDWriteTextLayout "technique". It is just less "hacky".
|
Will this PR eventually get reviewed? |
|
At a very quick glance: this seems to add quite a lot of code, but the old code is preserved and you say the new code has no advantage. What’s the point, then? Is there really nothing to gain here? |
My first message pretty much say it. It is just less "hacky". That's the only point. I would totally understand that you would reject the PR. |
|
Thanks. In that case: I’d like a second opinion from other maintainers, but personally, I think it’s good to have this patch here on GitHub for posterity—for whenever (if ever) we decide to drop support for Windows versions prior to 8.1—but I’d rather avoid merging it, because it seems to increase maintenance burden (and attack surface) for no real benefit: even if the new code is cleaner, the old code is still there and continues to be maintained. |
|
I’m not familiar with DirectWrite API, so i’m just basing this off descriptions from prior comments here: if there’s no benefit for users and it only increases code complexity atm, i agree merging doesn’t make sense until(if) it can replace the current "hacky" code path |
|
It would be better to just drop Windows 7/8 support. |
IDWriteFontFallback is available on Windows 8.1 and more.
There isn't any major advantage over the IDWriteTextLayout "technique". It is just less "hacky".