Bash script changes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @george-cindea for the script improvements, I left some code notes, resolve them and it will be merged -- truly appreciate your support! |
|
@all-contributors please add @george-cindea for code |
|
We had trouble processing your request. Please try again later. |
lfaoro
requested changes
Apr 26, 2025
scripts/get.sh
Outdated
| rm -f "$temp_check" | ||
| return 1 | ||
| fi | ||
| rm -f "$dir/$(basename "$temp_check")" | ||
| rm -f "$directory/$(basename "$temp_check")" |
There was a problem hiding this comment.
dir is short and clear, don't see the need to use directory
scripts/get.sh
Outdated
| esac | ||
| fi | ||
| } | ||
|
|
||
| # Configuration | ||
| APP_NAME=ssm | ||
| REPO="lfaoro/ssm" | ||
| LATEST_RELEASE_URL="https://github.com/${REPO}/releases/latest" | ||
| #Not used anywhere, if used externally, export it |
scripts/get.sh
Outdated
| error "download URL not accessible: ${DOWNLOAD_ARCHIVE_URL}" | ||
| fi | ||
|
|
||
| # Create temporary directory for extraction | ||
| TEMP_DIR=$(mktemp -d) || error "failed to create temporary directory" | ||
|
|
||
| # Download and extract the archive | ||
| if [ "${OS}" = "windows" ]; then | ||
| if [[ "${OS}" =~ "windows" ]]; then |
There was a problem hiding this comment.
you can remove windows support, as win users use ssm via WSL2
we don't release ssm.exe since 0.2.1
|
test again |
|
All done. don't forget to squash commits at/before merge :) |
|
too late. i merged as is :)) |
|
@all-contributors please add @george-cindea for code |
|
We had trouble processing your request. Please try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: